alt-orchestra/talos
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: require enabled bootloader for docker provisioner

Browse Source 
Otherwise, it doesn't make sense.

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
This commit is contained in:
Dmitriy Matrenichev 2024-05-24 15:33:14 +03:00
parent a9cf9b7892
commit eb510d9fdf
No known key found for this signature in database
GPG Key ID: 94B473337258BFD5
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/talosctl/cmd/mgmt/cluster/cluster.go
View File

@ -6,6 +6,7 @@
package cluster
import (
"errors"
"path/filepath"
"github.com/spf13/cobra"
@ -18,6 +19,13 @@ var Cmd = &cobra.Command{
Use: "cluster",
Short: "A collection of commands for managing local docker-based or QEMU-based clusters",
Long: ``,
PersistentPreRunE: func(*cobra.Command, []string) error {
if provisionerName == docker && !bootloaderEnabled {
return errors.New("docker provisioner requires bootloader to be enabled")
}
return nil
},
}
var (
@ -36,7 +44,7 @@ func init() {
defaultCNIDir = filepath.Join(talosDir, "cni")
}
Cmd.PersistentFlags().StringVar(&provisionerName, "provisioner", "docker", "Talos cluster provisioner to use")
Cmd.PersistentFlags().StringVar(&provisionerName, "provisioner", docker, "Talos cluster provisioner to use")
Cmd.PersistentFlags().StringVar(&stateDir, "state", defaultStateDir, "directory path to store cluster state")
Cmd.PersistentFlags().StringVar(&clusterName, "name", "talos-default", "the name of the cluster")
}

6
cmd/talosctl/cmd/mgmt/cluster/create.go
View File

@ -54,6 +54,8 @@ import (
)
const (
docker = "docker"
// gatewayOffset is the offset from the network address of the IP address of the network gateway.
gatewayOffset = 1
@ -446,7 +448,7 @@ func create(ctx context.Context) error {
var configBundleOpts []bundle.Option
if ports != "" {
if provisionerName != "docker" {
if provisionerName != docker {
return errors.New("exposed-ports flag only supported with docker provisioner")
}
@ -505,7 +507,7 @@ func create(ctx context.Context) error {
}
if talosVersion == "" {
if provisionerName == "docker" {
if provisionerName == docker {
parts := strings.Split(nodeImage, ":")
talosVersion = parts[len(parts)-1]