alt-orchestra/talos
1
0
Fork 0
Code Issues Pull Requests Actions 27 Packages Projects Releases Wiki Activity

fix: fix dashboard crash when a non-existent node is specified

Browse Source 
Prevent dashboard from crashing when a dead/non-existent node is specified on `talosctl --nodes`.

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
This commit is contained in:
Utku Ozdemir 2023-04-13 16:46:23 +02:00
parent 3e406d9b07
commit f14928b0a9
No known key found for this signature in database
GPG Key ID: 65933E76F0549B0D
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
internal/pkg/dashboard/components/header.go
View File

@ -122,38 +122,43 @@ func (widget *Header) redraw() {
}
func (widget *Header) updateNodeAPIData(node string, data *apidata.Node) {
sss := widget.getOrCreateNodeData(node)
nodeData := widget.getOrCreateNodeData(node)
if data == nil {
return
}
sss.cpuUsagePercent = fmt.Sprintf("%.1f%%", data.CPUUsageByName("usage")*100.0)
sss.memUsagePercent = fmt.Sprintf("%.1f%%", data.MemUsage()*100.0)
nodeData.cpuUsagePercent = fmt.Sprintf("%.1f%%", data.CPUUsageByName("usage")*100.0)
nodeData.memUsagePercent = fmt.Sprintf("%.1f%%", data.MemUsage()*100.0)
if data.Hostname != nil {
sss.hostname = data.Hostname.GetHostname()
nodeData.hostname = data.Hostname.GetHostname()
}
if data.Version != nil {
sss.version = data.Version.GetVersion().GetTag()
nodeData.version = data.Version.GetVersion().GetTag()
}
if data.SystemStat != nil {
sss.uptime = time.Since(time.Unix(int64(data.SystemStat.GetBootTime()), 0)).Round(time.Second).String()
nodeData.uptime = time.Since(time.Unix(int64(data.SystemStat.GetBootTime()), 0)).Round(time.Second).String()
}
if data.CPUsInfo != nil {
sss.numCPUs = fmt.Sprintf("%d", len(data.CPUsInfo.GetCpuInfo()))
sss.cpuFreq = widget.humanizeCPUFrequency(data.CPUsInfo.GetCpuInfo()[0].GetCpuMhz())
numCPUs := len(data.CPUsInfo.GetCpuInfo())
nodeData.numCPUs = fmt.Sprintf("%d", numCPUs)
if numCPUs > 0 {
nodeData.cpuFreq = widget.humanizeCPUFrequency(data.CPUsInfo.GetCpuInfo()[0].GetCpuMhz())
}
}
if data.Processes != nil {
sss.numProcesses = fmt.Sprintf("%d", len(data.Processes.GetProcesses()))
nodeData.numProcesses = fmt.Sprintf("%d", len(data.Processes.GetProcesses()))
}
if data.Memory != nil {
sss.totalMem = humanize.IBytes(data.Memory.GetMeminfo().GetMemtotal() << 10)
nodeData.totalMem = humanize.IBytes(data.Memory.GetMeminfo().GetMemtotal() << 10)
}
}