Commit Graph

25 Commits

Author SHA1 Message Date
Ryan McCabe
5dff3df564 fence_virtd: Add better debugging messages for the TCP listner
Improve some debugging messages for the TCP listener plugin.

Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
2017-05-27 15:04:11 -04:00
Ryan McCabe
cf48854295 fence_virtd: Fix potential unlocked pthread_cond_timedwait()
Fix a potential call to pthread_cond_timedwait() with an unlocked
mutex in the non-blocking syslog wrapper code.

Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
2017-05-26 14:39:38 -04:00
Ryan McCabe
2c909b78d8 fence_virtd: Fix select logic in listener plugins
Don't fail causing the daemon to exit when select() fails with errors
that indicate we should retry.

Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
2017-05-25 13:34:05 -04:00
Ryan McCabe
95a10ca43e Make the packet authentication code more resilient in the face
of transient failures.

Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
2017-05-23 15:36:23 -04:00
Masatake YAMATO
99d6fa5746 fence-virtd: Use perror only if the last system call returns an error.
Fix wrong usage of perror. perror is called when data filled
by read system call is shorter than expected. It is not an error
of system call.  In such case perror should not be used.
Similar code can be found in place where write system call is used.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
2015-02-08 01:31:36 +09:00
Masatake YAMATO
59b49215ab fence-virtd: Fix printing wrong system call in perror
perror("read") is called after write system call.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
2015-02-08 01:31:03 +09:00
Ryan McCabe
7231adafcb fence_virtd: Fix memcpy size params in the TCP plugin
Fix the size param of the memcpy calls in the TCP plugin.

Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
2012-10-26 18:15:53 -04:00
Ryan McCabe
2a8ac0a166 fence-virt: Fix fd leak when finding local addresses
Close the netlink fd before returning if recvfrom fails.

Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
2012-10-17 13:20:15 -04:00
Ryan McCabe
85ecac5cff fence-virt: Fix possible fd leak
Fix a fd leak that could occur if reading /dev/urandom failed.

Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
2012-10-17 13:20:08 -04:00
Ryan McCabe
c48c06819f fence-virt: Fix null pointer deref
Fix an unlikely null pointer dereference that could occur
subsequent to malloc failing.

Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
2012-10-17 13:20:02 -04:00
Ryan McCabe
f61626c108 Add a TCP listener plugin for use with viosproxy
Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
2012-06-01 15:22:02 -04:00
Lon Hohberger
d72630b973 Fix crash when we fail to read key file.
If hashing is requested and we have no key data, immediately fail.

Resolves: rhbz#758392

Signed-off-by: Lon Hohberger <lon@users.sourceforge.net>
2012-02-08 14:51:01 -05:00
Lon Hohberger
f7ccaa261a Fix static analysis errors
Signed-off-by: Lon Hohberger <lon@users.sourceforge.net>
2011-09-20 11:40:39 -04:00
Lon Hohberger
4f870c4fd0 Make symlink/compatibilty mode disabled by default
Signed-off-by: Lon Hohberger <lon@users.sourceforge.net>
2009-09-23 12:04:32 -04:00
Lon Hohberger
64d0f596f6 Clean up modular build
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-09-15 15:17:14 -04:00
Lon Hohberger
906b0f62b9 Initial port to autoconf
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-09-15 11:25:02 -04:00
Lon Hohberger
da7d3f4c9d Make debugging work from modules again
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-09-03 17:45:38 -04:00
Lon Hohberger
481905d8bf Add missing log.c. Enable syslog wrapping
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-08-31 09:38:28 -04:00
Lon Hohberger
d72d4a754f Move options.c to client directory
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-08-31 09:37:21 -04:00
Lon Hohberger
4ba33b27b9 Don't require specifying an interface in fence_virt.conf
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-08-21 14:55:54 -04:00
Lon Hohberger
f05920b01c Actually use the default port by default
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-08-21 14:21:14 -04:00
Lon Hohberger
082eb8be09 Fix missing carriage returns on debug prints
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-08-20 14:24:12 -04:00
Lon Hohberger
61e0cc19c9 Integrate config file processing
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-08-17 16:53:58 -04:00
Lon Hohberger
9ec497ddc6 Create server-side plugin architecture
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-08-17 12:44:06 -04:00
Lon Hohberger
55357fcd85 initial checkin
Signed-off-by: Lon Hohberger <lhh@redhat.com>
2009-07-28 10:46:53 -04:00