pkg/lists: uncrustify Makefile
The problem with the changed piece of code is that it would - both call cp(1) multiple times if multiple *_LIST variables were non-empty (which is usually the case), and - try to evaluate stdout of the called commands as a shell script (which would be empty unless someone passed e.g. -v to that cp(1) but it's crazy to rely on things like this). So the functions should prepare arguments for a single copy command that is predictable and could be made verbose. Ouch.
This commit is contained in:
parent
dc679621e2
commit
a86dd0c425
@ -21,12 +21,12 @@ TARGET := $(BUILDDIR)/$(SUFFIX)
|
||||
all: $(TARGET) $(GLOBAL_DEBUG) $(DOTBASE) copy-lists copy-groups
|
||||
@mp-commit "$(TARGET)" "requested $(SUFFIX) copied over"
|
||||
|
||||
# env | sort -u | grep _LISTS | xargs cp
|
||||
copy-lists:
|
||||
@# env | sort -u | grep _LISTS | xargs cp
|
||||
@$(foreach V, \
|
||||
$(filter %_LISTS,$(sort $(.VARIABLES))), \
|
||||
$(if $(filter environment% file,$(origin $V)),\
|
||||
$(shell cp --parents -at $(TARGET) -- $($V))))
|
||||
@cp --parents -at $(TARGET) -- \
|
||||
$(foreach V, \
|
||||
$(filter %_LISTS,$(sort $(.VARIABLES))), \
|
||||
$(if $(filter environment% file,$(origin $V)),$($V)))
|
||||
|
||||
copy-groups:
|
||||
@if [ -n "$(THE_GROUPS)$(MAIN_GROUPS)" ]; then \
|
||||
|
Loading…
Reference in New Issue
Block a user