andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

geo-rep: Don't log geo-rep safe errors in mount logs

Browse Source 
EEXIST and ENOENT are safe errors for geo-replication.
Since mkdir is captured in all the bricks of the changelog.
mkdir is tried multiple times as per the number of bricks.
The first one to process by gsyncd will succeed and all
others will get EEXIST.  Hence EEXIST is a safe error
and can be ignored. Similarly ENOENT also in rm -rf case.
And also gsyncd validates these errors and log them in
master if it is genuine error. This is coming up with
the patch http://review.gluster.org/#/c/10048/
Hence ignoring above said safe errors.

Change-Id: I10ae86b11d49c7c3ba2be3110dace6b33daa509e
BUG: 1210562
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10184
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
This commit is contained in:
Kotresh HR 2015-04-09 19:00:58 +05:30 committed by Vijay Bellur
parent b855aa0629
commit 009363dbc1
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libglusterfs/src/common-utils.h
View File

@ -287,6 +287,10 @@ int gf_set_log_ident (cmd_args_t *cmd_args);
if (gf_uuid_is_null (u))\
GF_ASSERT (!"uuid null");
#define GF_IGNORE_IF_GSYNCD_SAFE_ERROR(frame, op_errno) \
(((frame->root->pid == GF_CLIENT_PID_GSYNCD) && \
(op_errno == EEXIST || op_errno == ENOENT))?0:1) \
union gf_sock_union {
struct sockaddr_storage storage;
struct sockaddr_in6 sin6;

2
xlators/mount/fuse/src/fuse-bridge.c
View File

@ -1253,7 +1253,7 @@ fuse_err_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
state->loc.path ? state->loc.path : "ERR");
send_fuse_err (this, finh, 0);
} else {
} else if (GF_IGNORE_IF_GSYNCD_SAFE_ERROR(frame, op_errno)) {
gf_log ("glusterfs-fuse", GF_LOG_WARNING,
"%"PRIu64": %s() %s => -1 (%s)",
frame->root->unique,

3
xlators/protocol/client/src/client-rpc-fops.c
View File

@ -299,7 +299,8 @@ client3_3_mkdir_cbk (struct rpc_req *req, struct iovec *iov, int count,
rsp.op_errno, out);
out:
if (rsp.op_ret == -1) {
if (rsp.op_ret == -1 &&
GF_IGNORE_IF_GSYNCD_SAFE_ERROR(frame, rsp.op_errno)) {
gf_log (this->name, GF_LOG_WARNING,
"remote operation failed: %s. Path: %s",
strerror (gf_error_to_errno (rsp.op_errno)),