andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "quota/marker: fix mem-leak, free contribution node"

Browse Source 
This reverts commit 8ab6608accb62d6320d1fc1fbe651fcafd376270.

This patch is resulting in memory corruption:
http://build.gluster.org/job/rackspace-regression-2GB-triggered/11193/consoleFull

contribution object might be being used by some other transaction when
we free it. The correct way to handle this is to have a reference based
scheme to manage the contribution object.

Change-Id: Idf9993ed8268029073a3e2d699865587f20d9aea
BUG: 1207735
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11362
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
This commit is contained in:
Raghavendra Bhat 2015-06-23 00:25:38 +05:30 committed by Raghavendra G
parent 2b645af1d0
commit 01e42f25eb
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xlators/features/marker/src/marker-quota.c
View File

@ -2606,8 +2606,6 @@ mq_remove_contri (xlator_t *this, loc_t *loc, inode_contribution_t *contri)
}
UNLOCK (&contri->lock);
QUOTA_FREE_CONTRIBUTION_NODE (contri);
ret = 0;
out: