andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rpc/socket.c : Modify gf_log message in socket_poller code in case of error

Browse Source 
Problem:  In case of SSL after stopping the volume if client(mount point) is
          still trying to write the data on socket then it will throw an EIO
          error on that socket and given this log message is captured at every
          attempt this would flood the log file.

Solution: To reduce the frequency of stored log message use GF_LOG_OCCASIONALLY
          instead of gf_log.

BUG: 1381115
Change-Id: I66151d153c2cbfb017b3ebc4c52162278c0f537c
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15605
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
This commit is contained in:
Mohit Agrawal 2016-10-03 10:55:23 +05:30 committed by Raghavendra G
parent f0c588e5e6
commit 0701457500
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
rpc/rpc-transport/socket/src/socket.c
View File

@ -2407,7 +2407,7 @@ out:
return ret;
}
static int poll_err_cnt;
static void *
socket_poller (void *ctx)
{
@ -2543,8 +2543,11 @@ socket_poller (void *ctx)
break;
}
if (ret < 0 && errno != ENODATA) {
gf_log(this->name,GF_LOG_ERROR,
"error in polling loop");
GF_LOG_OCCASIONALLY (poll_err_cnt, this->name,
GF_LOG_ERROR,
"socket_poller %s failed (%s)",
this->peerinfo.identifier,
strerror (errno));
break;
}
if (priv->ot_gen != gen) {