andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mgmt/glusterd: Fix resource leak & unused value issues in glusterd-volume-ops.c

Browse Source 
Addresses CID: 1274132, 1325534

Change-Id: I176612ef5baf5618d543838a5f32db7dcd7002c3
updates: bz#789278
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
This commit is contained in:
Vijay Bellur 2018-08-13 14:52:09 -07:00 committed by Atin Mukherjee
parent 370f05546e
commit 11a9f9f0dc
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
xlators/mgmt/glusterd/src/glusterd-volume-ops.c
View File

@ -197,6 +197,7 @@ glusterd_check_brick_order(dict_t *dict, char *err_str)
gf_msg (this->name, GF_LOG_ERROR, ENOMEM,
GD_MSG_NO_MEMORY, "failed to allocate "
"memory");
freeaddrinfo (ai_info);
goto out;
}
ai_list_tmp1->info = ai_info;
@ -2290,6 +2291,8 @@ glusterd_op_create_volume (dict_t *dict, char **op_errstr)
"replica count for volume %s", volname);
goto out;
}
/* coverity[unused_value] arbiter count is optional */
ret = dict_get_int32 (dict, "arbiter-count",
&volinfo->arbiter_count);
} else if (GF_CLUSTER_TYPE_STRIPE == volinfo->type) {
@ -2335,6 +2338,8 @@ glusterd_op_create_volume (dict_t *dict, char **op_errstr)
"replica count for volume %s", volname);
goto out;
}
/* coverity[unused_value] arbiter count is optional */
ret = dict_get_int32 (dict, "arbiter-count",
&volinfo->arbiter_count);
} else if (GF_CLUSTER_TYPE_DISPERSE == volinfo->type) {