andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tier/unlink: symlink failed to unlink

Browse Source 
during unlink of a file, we will get stat just after
deleting the file, to see if the file is under migration or not.

but this stat call will fail for symlink if the actual file
was deleted.

So it is better not to send stat request from client if it is
a symlink as we are not migrating symlink.

Change-Id: Idc033b24fa3522b5261e579889d2195b43419682
BUG: 1293963
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13074
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
This commit is contained in:
Mohammed Rafi KC 2015-12-23 23:37:54 +05:30 committed by Dan Lambright
parent 72e7366131
commit 137b11d616
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
xlators/cluster/dht/src/tier-common.c
View File

@ -537,12 +537,16 @@ tier_unlink (call_frame_t *frame, xlator_t *this, loc_t *loc, int xflag,
}
local->flags = xflag;
if (hashed_subvol == cached_subvol) {
if (IA_ISREG (loc->inode->ia_type) &&
(hashed_subvol == cached_subvol)) {
/*
* File resides in cold tier. We need to stat
* the file to see if it is being promoted.
* If yes we need to delete the destination
* file as well.
*
* Currently we are doing this check only for
* regular files.
*/
xdata = xdata ? dict_ref (xdata) : dict_new ();
if (xdata) {

3
xlators/storage/posix/src/posix.c
View File

@ -1749,7 +1749,8 @@ posix_unlink (call_frame_t *frame, xlator_t *this,
goto out;
}
if (xdata && dict_get (xdata, DHT_IATT_IN_XDATA_KEY)) {
if (IA_ISREG (loc->inode->ia_type) &&
xdata && dict_get (xdata, DHT_IATT_IN_XDATA_KEY)) {
fdstat_requested = 1;
}