andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tests: remove tests/bugs/core/bug-1421590-brick-mux-reuse-ports.t

Browse Source 
bug-1421590-brick-mux-reuse-ports.t seems to be a bad test to me and here is my
reasoning:

This test tries to check if the ports are reused or not. When a volume is
restarted, by the time glusterd tries to allocate a new port to the one of the
brick processes of the volume there is no guarantee that the older port will be
allocated given the kernel might take some extra time to free up the port between
this time frame. From
https://build.gluster.org/job/regression-test-burn-in/2932/console we can
clearly see that post restart of the volume, glusterd allocated port 49153 &
49155 for brick1 & brick2 respectively but the test was expecting the ports to
be matched with 49155 & 49156 which were allocated before the volume was
restarted.

Change-Id: Id887bf28445261d4de04fc7502e58057659c9512
BUG: 1441035
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17033
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
This commit is contained in:
Atin Mukherjee 2017-04-11 09:25:48 +05:30
parent 10a797c26f
commit 1612355327
1 changed files with 0 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
tests/bugs/core/bug-1421590-brick-mux-reuse-ports.t
View File

@ -1,60 +0,0 @@
#!/bin/bash
. $(dirname $0)/../../include.rc
. $(dirname $0)/../../traps.rc
. $(dirname $0)/../../volume.rc
function get_nth_brick_port_for_volume () {
local VOL=$1
local n=$2
$CLI volume status $VOL --xml | sed -ne 's/.*<port>\([-0-9]*\)<\/port>/\1/p' \
| head -n $n | tail -n 1
}
TEST glusterd
TEST $CLI volume set all cluster.brick-multiplex on
push_trapfunc "$CLI volume set all cluster.brick-multiplex off"
push_trapfunc "cleanup"
TEST $CLI volume create $V0 $H0:$B0/brick{0,1}
TEST $CLI volume start $V0
# We can't expect a valid port number instantly. We need to wait for the
# bricks to finish coming up. In every other case we use EXPECT_WITHIN, but
# this first time we need to wait more explicitly.
sleep $PROCESS_UP_TIMEOUT
port_brick0=$(get_nth_brick_port_for_volume $V0 1)
# restart the volume
TEST $CLI volume stop $V0
TEST $CLI volume start $V0
EXPECT_WITHIN $PROCESS_UP_TIMEOUT $port_brick0 get_nth_brick_port_for_volume $V0 1
TEST $CLI volume stop $V0
TEST $CLI volume set all cluster.brick-multiplex off
TEST $CLI volume start $V0
EXPECT_WITHIN $PROCESS_UP_TIMEOUT $port_brick0 get_nth_brick_port_for_volume $V0 1
port_brick1=$(get_nth_brick_port_for_volume $V0 2)
# restart the volume
TEST $CLI volume stop $V0
TEST $CLI volume start $V0
EXPECT_WITHIN $PROCESS_UP_TIMEOUT $port_brick0 get_nth_brick_port_for_volume $V0 1
EXPECT_WITHIN $PROCESS_UP_TIMEOUT $port_brick1 get_nth_brick_port_for_volume $V0 2
TEST $CLI volume stop $V0
TEST $CLI volume set all cluster.brick-multiplex on
TEST $CLI volume start $V0
EXPECT_WITHIN $PROCESS_UP_TIMEOUT $port_brick0 get_nth_brick_port_for_volume $V0 1