andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

nfs: avoid logging invalid fdctx in case of anonymous fds

Browse Source 
if get_fd_ctx fails (as in case of anonymous fds), overwhelming
amount of entries are seen in the nfs log, causing dd and other
heavy i/o operations to become unresponsive. this patch logs an
invalid fdctx only if it is not an anonymous fd.

Change-Id: I4e917d150d6a053af77d47a94a2f1c2633acadb5
BUG: 787365
Signed-off-by: Rajesh Amaravathi <rajesh@redhat.com>
Reviewed-on: http://review.gluster.com/2747
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
This commit is contained in:
Rajesh Amaravathi 2012-02-14 16:28:44 +05:30 committed by Vijay Bellur
parent 22d2abe742
commit 1fbed11ead
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
xlators/protocol/client/src/client-lk.c
View File

@ -362,7 +362,7 @@ destroy_client_lock (client_posix_lock_t *lock)
int32_t
delete_granted_locks_owner (fd_t *fd, gf_lkowner_t *owner)
{
clnt_fd_ctx_t *fdctx = NULL;
clnt_fd_ctx_t *fdctx = NULL;
client_posix_lock_t *lock = NULL;
client_posix_lock_t *tmp = NULL;
xlator_t *this = NULL;
@ -375,8 +375,9 @@ delete_granted_locks_owner (fd_t *fd, gf_lkowner_t *owner)
this = THIS;
fdctx = this_fd_get_ctx (fd, this);
if (!fdctx) {
gf_log (this->name, GF_LOG_WARNING,
"fdctx not valid");
if (!fd_is_anonymous (fd))
gf_log (this->name, GF_LOG_WARNING,
"fdctx not valid");
ret = -1;
goto out;
}