andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

protocol/client: Fix potential mem-leaks

Browse Source 
Commit 93eaeb9c93be3232f24e840044d560f9f0e66f71 introduces
leaks in INODELK callback where a dict is unserialized twice,
leading to dict leaks.

Change-Id: I219ccb2279f237ebc2e4fc366af4775a461929b8
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/16156
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
This commit is contained in:
Krutika Dhananjay 2016-12-16 09:31:41 +05:30 committed by Pranith Kumar Karampuri
parent d2dff6320a
commit 2d87431c51
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
xlators/protocol/client/src/client-handshake.c
View File

@ -86,6 +86,7 @@ out:
/* Don't use 'GF_FREE', this is allocated by libc */ /* Don't use 'GF_FREE', this is allocated by libc */
free (rsp.spec); free (rsp.spec);
free (rsp.xdata.xdata_val);
return 0; return 0;
} }

4
xlators/protocol/client/src/client-rpc-fops.c
View File

@ -1531,10 +1531,6 @@ client3_3_inodelk_cbk (struct rpc_req *req, struct iovec *iov, int count,
goto out; goto out;
} }
GF_PROTOCOL_DICT_UNSERIALIZE (this, xdata, (rsp.xdata.xdata_val),
(rsp.xdata.xdata_len), ret,
rsp.op_errno, out);
ret = client_post_inodelk (this, &rsp, &xdata); ret = client_post_inodelk (this, &rsp, &xdata);
if (ret < 0) if (ret < 0)
goto out; goto out;