andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

syncop: remove unnecessary call to gf_backtrace_save()

Browse Source 
A call to gf_backtrace_save() was done on each context switch of a
synctask. The backtrace is generated writing to the filesystem, so it
can have an important impact on latency.

The generated backtrace was not used anywhere, so it's been removed.

Change-Id: I399a93b932c5b6e981c696c72c3e1ef44710ba52
Updates: bz#1193929
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
This commit is contained in:
Xavi Hernandez 2019-01-31 08:13:58 +01:00 committed by Shyamsundar Ranganathan
parent 8bc33a2d90
commit 2fb445babd
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libglusterfs/src/glusterfs/syncop.h
View File

@ -73,7 +73,6 @@ struct synctask {
int done;
struct list_head waitq; /* can wait only "once" at a time */
char btbuf[GF_BACKTRACE_LEN];
};
struct syncproc {

1
libglusterfs/src/syncop.c
View File

@ -327,7 +327,6 @@ synctask_yield(struct synctask *task)
if (task->state != SYNCTASK_DONE) {
task->state = SYNCTASK_SUSPEND;
(void)gf_backtrace_save(task->btbuf);
}
if (swapcontext(&task->ctx, &task->proc->sched) < 0) {
gf_msg("syncop", GF_LOG_ERROR, errno, LG_MSG_SWAPCONTEXT_FAILED,