andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Upcall: Fix an issue with invalidating parent entries

Browse Source 
Any directory or file creation should result in cache-invalidation
requests sent to parent directory. However that is not the case
currently due to a bug while processing these requests in the
upcall xlator. We need to do invalidation checks on parent inode.

Fixed the same. Also fixed an issue with null client entries while
sending upcall notifications.

Change-Id: I3da7c79091291ba36fd8f8ebcfebcd77a192f250
BUG: 1235542
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: http://review.gluster.org/11387
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Meghana M <mmadhusu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
This commit is contained in:
Soumya Koduri 2015-06-25 00:47:19 +05:30 committed by Kaleb KEITHLEY
parent 875aa01ec8
commit 35d24f0c96
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
xlators/features/upcall/src/upcall.c
View File

@ -635,7 +635,7 @@ up_mkdir_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
}
/* invalidate parent's entry too */
flags = UP_PARENT_DENTRY_FLAGS;
flags = UP_TIMES;
upcall_cache_invalidate (frame, this, client, local->inode, flags,
stbuf, postparent, NULL);
@ -655,7 +655,7 @@ up_mkdir (call_frame_t *frame, xlator_t *this,
EXIT_IF_UPCALL_OFF (this, out);
local = upcall_local_init (frame, this, loc->inode);
local = upcall_local_init (frame, this, loc->parent);
if (!local) {
op_errno = ENOMEM;
goto err;
@ -697,7 +697,7 @@ up_create_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
/* As its a new file create, no need of sending notification */
/* However invalidate parent's entry */
flags = UP_PARENT_DENTRY_FLAGS;
flags = UP_TIMES;
upcall_cache_invalidate (frame, this, client, local->inode, flags,
stbuf, postparent, NULL);
@ -718,7 +718,7 @@ up_create (call_frame_t *frame, xlator_t *this,
EXIT_IF_UPCALL_OFF (this, out);
local = upcall_local_init (frame, this, loc->inode);
local = upcall_local_init (frame, this, loc->parent);
if (!local) {
op_errno = ENOMEM;
@ -1047,7 +1047,7 @@ up_mknod_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
}
/* invalidate parent's entry too */
flags = UP_PARENT_DENTRY_FLAGS;
flags = UP_TIMES;
upcall_cache_invalidate (frame, this, client, local->inode, flags,
buf, postparent, NULL);
@ -1067,7 +1067,7 @@ up_mknod (call_frame_t *frame, xlator_t *this, loc_t *loc,
EXIT_IF_UPCALL_OFF (this, out);
local = upcall_local_init (frame, this, loc->inode);
local = upcall_local_init (frame, this, loc->parent);
if (!local) {
op_errno = ENOMEM;
goto err;
@ -1108,7 +1108,7 @@ up_symlink_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
}
/* invalidate parent's entry too */
flags = UP_PARENT_DENTRY_FLAGS;
flags = UP_TIMES;
upcall_cache_invalidate (frame, this, client, local->inode, flags,
buf, postparent, NULL);
@ -1129,7 +1129,7 @@ up_symlink (call_frame_t *frame, xlator_t *this,
EXIT_IF_UPCALL_OFF (this, out);
local = upcall_local_init (frame, this, loc->inode);
local = upcall_local_init (frame, this, loc->parent);
if (!local) {
op_errno = ENOMEM;
goto err;