andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

timer: Fix use after free issue

Browse Source 
Change-Id: I056c9777b242a11af7f576ad19b2db93dbdf82d4
BUG: 1215117
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10367
Reviewed-by: Poornima G <pgurusid@redhat.com>
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
This commit is contained in:
Pranith Kumar K 2015-04-24 16:24:52 +05:30 committed by Vijay Bellur
parent b72bc58ecc
commit 48de998d58
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libglusterfs/src/timer.c
View File

@ -176,12 +176,16 @@ gf_timer_proc (void *ctx)
}
pthread_mutex_unlock (&reg->lock);
if (need_cbk) {
old_THIS = NULL;
if (event->xl) {
old_THIS = THIS;
THIS = event->xl;
}
event->callbk (event->data);
if (event->xl) {
/*This callbk above would have freed the event
* by calling timer_cancel, don't ever touch it
* again*/
if (old_THIS) {
THIS = old_THIS;
}
}