andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

afr: Fix excessive logging in afr_accuse_smallfiles()

Browse Source 
Commit 2b7226f9d3470d8fe4c98c1fddb06e7f641e364d did not check for the
validity of a dict before doing a dict_get. Fix that.

Change-Id: Ie21f4da19256b17196f242cd8fd5bb76b0a69c1e
BUG: 1294053
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13077
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
This commit is contained in:
Ravishankar N 2015-12-24 15:22:05 +05:30 committed by Pranith Kumar Karampuri
parent e4de816ae1
commit 4c1b667201
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
xlators/cluster/afr/src/afr-common.c
View File

@ -637,7 +637,8 @@ afr_accuse_smallfiles (xlator_t *this, struct afr_reply *replies,
priv = this->private;
for (i = 0; i < priv->child_count; i++) {
if (dict_get (replies[i].xdata, GLUSTERFS_BAD_INODE))
if (replies[i].valid && replies[i].xdata &&
dict_get (replies[i].xdata, GLUSTERFS_BAD_INODE))
continue;
if (data_accused[i])
continue;