andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

features/snapview-server: remove the ret variable

Browse Source 
Used only once to store the return value of a function.

Change-Id: Ib2b9db847b5f652ce46f220297d9c7c3503eaea2
fixes: #230
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
This commit is contained in:
Raghavendra Bhat 2018-09-07 14:00:59 -04:00 committed by Amar Tumballi
parent a9f3ef105f
commit 5384787d41
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
xlators/features/snapview-server/src/snapview-server.c
View File

@ -323,7 +323,6 @@ svs_lookup_entry (xlator_t *this, loc_t *loc, struct iatt *buf,
svs_inode_t *inode_ctx = NULL;
glfs_object_t *parent_object = NULL;
uuid_t gfid = {0, };
int ret = -1;
GF_VALIDATE_OR_GOTO ("snapview-server", this, out);
@ -367,13 +366,12 @@ svs_lookup_entry (xlator_t *this, loc_t *loc, struct iatt *buf,
if (gf_uuid_is_null (loc->gfid) &&
gf_uuid_is_null (loc->inode->gfid)) {
ret = svs_uuid_generate (this, gfid, parent_ctx->snapname,
object->gfid);
if (svs_uuid_generate (this, gfid, parent_ctx->snapname,
object->gfid)) {
/*
* should op_errno be something else such as
* EINVAL or ESTALE?
*/
if (ret) {
op_ret = -1;
*op_errno = EIO;
goto out;