andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

glusterd: Deadcode Coverity issue

Browse Source 
This patch will fix coverity issue 74 from [1].

we are updating ret value line number 5011, and
immediately checking whether ret is having non
zero value at line number 5013.If ret is 0, then
only we continue to execute and we can reach line
number 5036. By the time we reach 5036, ret value
is always 0. So this block of code is redundant
here and removing it.

[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-07-23-5fa004f3/html/

Updates: bz#789278

Change-Id: Ia6e8ba2936e350f0d29a9151ab786622f5e750db
Signed-off-by: Oshank Kumar <okumar@redhat.com>
This commit is contained in:
Oshank Kumar 2018-07-24 16:26:18 +05:30 committed by Atin Mukherjee
parent 5fa004f3c4
commit 59401e705b
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xlators/mgmt/glusterd/src/glusterd-utils.c
View File

@ -5033,8 +5033,6 @@ glusterd_compare_friend_data (dict_t *peer_data, int32_t *status,
glusterd_launch_synctask
(glusterd_import_friend_volumes_synctask,
peer_data_copy);
if (ret)
goto out;
}
out: