andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

posix: Revert modifying op_errno in __posix_fd_ctx_get

Browse Source 
https://review.gluster.org/#/c/17414/ converted ENOENT to EBADFD because
ENOENT is not a valid error for fd based operations, but this apparently
breaks dht rebalance behaviour (see comments in the backport 17517. So
reverting that part of the change.

Change-Id: Idcf5c65a47b096a3766cf7f20ca938d988572052
BUG: 1456582
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://review.gluster.org/17565
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
This commit is contained in:
Ravishankar N 2017-06-19 13:45:55 +05:30 committed by Pranith Kumar Karampuri
parent 3011af6773
commit 61924b98a6
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
xlators/storage/posix/src/posix-helpers.c
View File

@ -1685,13 +1685,11 @@ __posix_fd_ctx_get (fd_t *fd, xlator_t *this, struct posix_fd **pfd_p,
if (fd->inode->ia_type == IA_IFDIR) {
dir = sys_opendir (real_path);
if (!dir) {
(errno == ENOENT) ? (op_errno = EBADF) :
(op_errno = errno);
gf_msg (this->name, GF_LOG_ERROR, errno,
op_errno = errno;
gf_msg (this->name, GF_LOG_ERROR, op_errno,
P_MSG_READ_FAILED,
"Failed to get anonymous fd for "
"real_path: %s. Returning %s.", real_path,
strerror(op_errno));
"real_path: %s.", real_path);
GF_FREE (pfd);
pfd = NULL;
goto out;
@ -1712,13 +1710,11 @@ __posix_fd_ctx_get (fd_t *fd, xlator_t *this, struct posix_fd **pfd_p,
_fd = open (unlink_path, fd->flags);
}
if (_fd == -1) {
(errno == ENOENT) ? (op_errno = EBADF) :
(op_errno = errno);
gf_msg (this->name, GF_LOG_ERROR, errno,
op_errno = errno;
gf_msg (this->name, GF_LOG_ERROR, op_errno,
P_MSG_READ_FAILED,
"Failed to get anonymous fd for "
"real_path: %s. Returning %s.", real_path,
strerror(op_errno));
"real_path: %s.", real_path);
GF_FREE (pfd);
pfd = NULL;
goto out;