andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gluster-cli: Fixing operand error and removing logically dead code.

Browse Source 
Assign used instead of comparison
Coverity CIDs:
1124391
1124346
1124369
1124370
1124702
1124390
1124397

Change-Id: If015382917cad65edc2fee38ae6328f1d072d6f6
BUG: 789278
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9574
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
This commit is contained in:
Nandaja Varma 2015-02-04 13:21:50 +05:30 committed by Vijay Bellur
parent e92270044e
commit 6df8d1d878
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cli/src/cli-cmd-volume.c
View File

@ -374,12 +374,6 @@ cli_cmd_volume_start_cbk (struct cli_state *state, struct cli_cmd_word *word,
goto out;
}
if (ret < 0) {
gf_log (THIS->name, GF_LOG_ERROR,
"failed to serialize dict");
goto out;
}
proc = &cli_rpc_prog->proctable[GLUSTER_CLI_START_VOLUME];
CLI_LOCAL_INIT (local, words, frame, dict);
@ -2414,7 +2408,7 @@ cli_cmd_volume_clearlocks_cbk (struct cli_state *state,
out:
if (ret) {
cli_cmd_sent_status_get (&sent);
if ((sent == 0) && (parse_error = 0))
if ((sent == 0) && (parse_error == 0))
cli_out ("Volume clear-locks failed");
}