andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

LinuxRPM/Makefile: fix backquote which was triggering recursive make

Browse Source 
The following Makefile snippet:

--snip--
all:
	@echo "To build RPMS run `make glusterrpms`"
--snip--

was using `backquotes` in the string, and thereby triggering a nested
make on "glusterrpms" target implicitly as part of 'make all', thus
defeating the intention.

So use single quotes instead of backquotes.

It is unexplained why this nested 'make glusterrpms' was not called on
the build server during regression test.

Change-Id: I8a8d1d4f565d03cfb27341e6183af5b09530eb60
BUG: 819130
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4532
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
This commit is contained in:
Anand Avati 2013-02-17 21:46:47 -08:00
parent 1d172d6ee1
commit 6f67898842
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extras/LinuxRPM/Makefile.am
View File

@ -6,7 +6,7 @@ GFS_SPEC = ../../glusterfs.spec
.PHONY: all
all:
@echo "To build RPMS run `make glusterrpms`"
@echo "To build RPMS run 'make glusterrpms'"
.PHONY: glusterrpms prep srcrpm testsrpm clean