andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

posix: buffer_size_warning coverity fix

Browse Source 
Defect: CID 1398469- Calling strncpy with a maximum size argument
of 4096 bytes on destination array key of size 4096 bytes might
leave the destination string unterminated.

Fix: Using snprintf instead of strncpy.

updates: bz#789278

Change-Id: I4fdcd0cbf3af8b2ded94603d92d1ceb4112284c4
Signed-off-by: Harpreet Kaur <hlalwani@redhat.com>
This commit is contained in:
Harpreet Kaur 2018-12-27 20:20:56 +05:30 committed by Amar Tumballi
parent 63088d8225
commit 7a84e705ed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xlators/storage/posix/src/posix-helpers.c
View File

@ -367,7 +367,7 @@ _posix_get_marker_all_contributions(posix_xattr_filler_t *filler)
list_offset = 0;
while (remaining_size > 0) {
strncpy(key, list + list_offset, sizeof(key));
snprintf(key, sizeof(key), "%s", list + list_offset);
if (fnmatch(marker_contri_key, key, 0) == 0) {
ret = _posix_xattr_get_set_from_backend(filler, key);
}