andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

client/protocol: fix the log level for removexattr_cbk

Browse Source 
noticed that server protocol actually logs all the errors for
removexattr as INFO, instead of WARNING like client, and hence,
doesn't create a confusion in user.

updates: bz#1576418
Change-Id: Ia6681e9ee433fda3c77a4509906c78333396e339
Signed-off-by: Amar Tumballi <amarts@redhat.com>
This commit is contained in:
Amar Tumballi 2018-05-09 00:56:11 +05:30
parent 9ead9a6690
commit 7ac79fb033
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
xlators/protocol/client/src/client-rpc-fops.c
View File

@ -1194,7 +1194,12 @@ client3_3_removexattr_cbk (struct rpc_req *req, struct iovec *iov, int count,
ret = client_post_removexattr (this, &rsp, &xdata);
out:
if (rsp.op_ret == -1) {
if ((ENODATA == rsp.op_errno) || (ENOATTR == rsp.op_errno))
/* EPERM/EACCESS is returned some times in case of selinux
attributes, or other system attributes which may not be
possible to remove from an user process is encountered.
we can't treat it as an error */
if ((ENODATA == rsp.op_errno) || (ENOATTR == rsp.op_errno) ||
(EPERM == rsp.op_errno) || (EACCES == rsp.op_errno))
loglevel = GF_LOG_DEBUG;
else
loglevel = GF_LOG_WARNING;

7
xlators/protocol/client/src/client-rpc-fops_v2.c
View File

@ -1012,7 +1012,12 @@ client4_0_removexattr_cbk (struct rpc_req *req, struct iovec *iov, int count,
xdr_to_dict (&rsp.xdata, &xdata);
out:
if (rsp.op_ret == -1) {
if ((ENODATA == rsp.op_errno) || (ENOATTR == rsp.op_errno))
/* EPERM/EACCESS is returned some times in case of selinux
attributes, or other system attributes which may not be
possible to remove from an user process is encountered.
we can't treat it as an error */
if ((ENODATA == rsp.op_errno) || (ENOATTR == rsp.op_errno) ||
(EPERM == rsp.op_errno) || (EACCES == rsp.op_errno))
loglevel = GF_LOG_DEBUG;
else
loglevel = GF_LOG_WARNING;