andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "features/shard: Make o-direct writes work with sharding"

Browse Source 
This reverts commit c272c71391cea9db817f4e7e38cfc25a7cff8bd5.

This is for two reasons:
1) It introduces high fop latencies
2) Even with the patch, there is no true odirect behavior since the
   workaround in the patch doesn't reduce the caching done in kernel's
   page cache as far as writes on anon fds associated with individual
   shards is concerned.

Change-Id: Iaf411198b56237ca0601deaf17f69ef178d7e769
BUG: 1335818
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/14328
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
This commit is contained in:
Krutika Dhananjay 2016-05-13 15:18:22 +05:30 committed by Pranith Kumar Karampuri
parent eb705e090a
commit 7d67d7d7a6
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
xlators/features/shard/src/shard.c
View File

@ -3591,7 +3591,6 @@ shard_common_inode_write_do (call_frame_t *frame, xlator_t *this)
shard_local_t *local = NULL;
struct iovec *vec = NULL;
gf_boolean_t wind_failed = _gf_false;
gf_boolean_t odirect = _gf_false;
off_t orig_offset = 0;
off_t shard_offset = 0;
off_t vec_offset = 0;
@ -3622,9 +3621,6 @@ shard_common_inode_write_do (call_frame_t *frame, xlator_t *this)
return 0;
}
if ((fd->flags & O_DIRECT) && (local->fop == GF_FOP_WRITE))
odirect = _gf_true;
while (cur_block <= last_block) {
if (wind_failed) {
shard_common_inode_write_do_cbk (frame,
@ -3682,8 +3678,6 @@ shard_common_inode_write_do (call_frame_t *frame, xlator_t *this)
NULL, NULL);
goto next;
}
if (odirect)
local->flags |= O_SYNC;
}
shard_common_inode_write_wind (frame, this, anon_fd,