andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Free the mutex even if we can't allocate a inode

Browse Source 
Since GF_CHECK_ALLOC may jump to out, with a mutex locked,
we need to make sure the mutex is unlocked before returning.

Error found by coverity

Change-Id: I81011e18afc90c2c0fd489ceeb78d90ae31e35ba
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16793
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
This commit is contained in:
Michael Scherer 2017-03-01 16:38:21 +01:00 committed by Vijay Bellur
parent fabce246ae
commit 7ddab8fa7b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xlators/features/leases/src/leases-internal.c
View File

@ -482,8 +482,8 @@ add_inode_to_client_list (xlator_t *this, inode_t *inode, const char *client_uid
"cleanup list, gfid(%s)", inode, client_uid,
uuid_utoa (inode->gfid));
}
pthread_mutex_unlock (&priv->mutex);
out:
pthread_mutex_unlock (&priv->mutex);
return ret;
}