From 7ddab8fa7b05343e4a110fadc227675479f9e358 Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Wed, 1 Mar 2017 16:38:21 +0100 Subject: [PATCH] Free the mutex even if we can't allocate a inode Since GF_CHECK_ALLOC may jump to out, with a mutex locked, we need to make sure the mutex is unlocked before returning. Error found by coverity Change-Id: I81011e18afc90c2c0fd489ceeb78d90ae31e35ba BUG: 789278 Signed-off-by: Michael Scherer Reviewed-on: https://review.gluster.org/16793 Smoke: Gluster Build System Tested-by: Michael Scherer NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Raghavendra Bhat Reviewed-by: Vijay Bellur --- xlators/features/leases/src/leases-internal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xlators/features/leases/src/leases-internal.c b/xlators/features/leases/src/leases-internal.c index 6884b5812..1f79e5544 100644 --- a/xlators/features/leases/src/leases-internal.c +++ b/xlators/features/leases/src/leases-internal.c @@ -482,8 +482,8 @@ add_inode_to_client_list (xlator_t *this, inode_t *inode, const char *client_uid "cleanup list, gfid(%s)", inode, client_uid, uuid_utoa (inode->gfid)); } - pthread_mutex_unlock (&priv->mutex); out: + pthread_mutex_unlock (&priv->mutex); return ret; }