andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

logging: Fix to avoid excessive logging.

Browse Source 
mem_get function: Log message related to mem_pool 
calloc is removed  as its been calculated in mempool
'stats'.  This messgae is consuming nearly half of 
the total log messages in DEBUG mode.

dht_hash_compute function: Changed log level from DEBUG 
to TRACE.

client_fdctx_destroy function: Changed log  level from DEBUG 
to TRACE.

Change-Id: Ic948db0419e76df4e95ebd0cabaf66eadbaada6b
BUG: 966851
Signed-off-by: Venkatesh Somyajulu <vsomyaju@redhat.com>
Reviewed-on: http://review.gluster.org/5086
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
This commit is contained in:
Venkatesh Somyajulu 2013-05-24 12:57:19 +05:30 committed by Vijay Bellur
parent 1a5e8638a1
commit 84e966cc8b
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libglusterfs/src/mem-pool.c
View File

@ -418,8 +418,6 @@ mem_get (struct mem_pool *mem_pool)
mem_pool->max_stdalloc = mem_pool->curr_stdalloc;
ptr = GF_CALLOC (1, mem_pool->padded_sizeof_type,
gf_common_mt_mem_pool);
gf_log_callingfn ("mem-pool", GF_LOG_DEBUG, "Mem pool is full. "
"Callocing mem");
/* Memory coming from the heap need not be transformed from a
* chunkhead to a usable pointer since it is not coming from

2
xlators/cluster/dht/src/dht-hashfn.c
View File

@ -94,7 +94,7 @@ dht_hash_compute (xlator_t *this, int type, const char *name, uint32_t *hash_p)
if (!munged && priv->rsync_regex_valid) {
len = strlen(name) + 1;
rsync_friendly_name = alloca(len);
gf_log (this->name, GF_LOG_DEBUG, "trying regex for %s", name);
gf_log (this->name, GF_LOG_TRACE, "trying regex for %s", name);
munged = dht_munge_name (name, rsync_friendly_name, len,
&priv->rsync_regex);
if (munged) {

4
xlators/protocol/client/src/client-rpc-fops.c
View File

@ -2757,7 +2757,7 @@ client_fdctx_destroy (xlator_t *this, clnt_fd_ctx_t *fdctx)
if (fdctx->is_dir) {
gfs3_releasedir_req req = {{0,},};
req.fd = fdctx->remote_fd;
gf_log (this->name, GF_LOG_DEBUG, "sending releasedir on fd");
gf_log (this->name, GF_LOG_TRACE, "sending releasedir on fd");
client_submit_request (this, &req, fr, &clnt3_3_fop_prog,
GFS3_OP_RELEASEDIR,
client3_3_releasedir_cbk,
@ -2766,7 +2766,7 @@ client_fdctx_destroy (xlator_t *this, clnt_fd_ctx_t *fdctx)
} else {
gfs3_release_req req = {{0,},};
req.fd = fdctx->remote_fd;
gf_log (this->name, GF_LOG_DEBUG, "sending release on fd");
gf_log (this->name, GF_LOG_TRACE, "sending release on fd");
client_submit_request (this, &req, fr, &clnt3_3_fop_prog,
GFS3_OP_RELEASE,
client3_3_release_cbk, NULL,