andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

build: Remove redundant options from GF_CFLAGS

Browse Source 
While configuring, GF_CFLAGS is being populated with redudndant
options as follows:

Normal mode:
GF_CFLAGS = -g -O2 -g -O2 -Wformat -Werror=format-security \
            -g -O2 -g -O2 -Wformat -Werror=format-security \
            -Werror=implicit-function-declaration
Debug mode:
GF_CFLAGS = -g -O2 -g -O0 -DDEBUG -Wformat -Werror=format-security \
            -g -O2 -g -O0 -DDEBUG -Wformat -Werror=format-security \
            -Werror=implicit-function-declaration

This patch is to remove this redundancy of options.

Change-Id: Idf6f2536c2a8ae24ba257681fbe9dfdb8bfa4f19
BUG: 1198849
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-on: http://review.gluster.org/12714
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
This commit is contained in:
Anoop C S 2015-11-23 12:20:09 +05:30 committed by Jeff Darcy
parent b8b050c370
commit 86701a0ece
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
configure.ac
View File

@ -934,15 +934,18 @@ fi
dnl check for gcc -Werror=implicit-function-declaration
saved_CFLAGS=$CFLAGS
saved_GF_CFLAGS=$GF_CFLAGS
CFLAGS="-Werror=implicit-function-declaration"
GF_CFLAGS="-Werror=implicit-function-declaration"
AC_MSG_CHECKING([whether $CC accepts -Werror=implicit-function-declaration])
AC_COMPILE_IFELSE([AC_LANG_PROGRAM()], [cc_werror_implicit=yes], [cc_werror_implicit=no])
echo $cc_werror_implicit
if test "x$cc_werror_implicit" = "xno"; then
CFLAGS="$saved_CFLAGS"
GF_CFLAGS="$saved_GF_CFLAGS"
else
CFLAGS="$saved_CFLAGS $CFLAGS"
GF_CFLAGS="$GF_CFLAGS $CFLAGS"
GF_CFLAGS="$saved_GF_CFLAGS $GF_CFLAGS"
fi
dnl clang is mostly GCC-compatible, but its version is much lower,