andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

features/changelog: fix possible illegal memory access (CID 1288821)

Browse Source 
Coverity CID 1288821

strncpy executed with a limit equal to the target array
size potentially leaves the target string not null terminated.
Make sure the copied string is a valid 0 terminated string.

Change-Id: I5ecc60549864cf50e3facbb8a2d9228cd67b57b5
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10061
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
This commit is contained in:
Michael Adam 2015-03-31 09:41:10 +02:00 committed by Venky Shankar
parent e1e41ae678
commit 90f72efed8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
xlators/features/changelog/lib/src/gf-changelog.c
View File

@ -357,7 +357,8 @@ gf_setup_brick_connection (xlator_t *this,
entry->connstate = GF_CHANGELOG_CONN_STATE_PENDING;
entry->notify = brick->filter;
(void) strncpy (entry->brick, brick->brick_path, PATH_MAX);
(void) strncpy (entry->brick, brick->brick_path, PATH_MAX-1);
entry->brick[PATH_MAX-1] = 0;
entry->this = this;
entry->invokerxl = xl;