andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

core: move logs which are only developer relevant to DEBUG level

Browse Source 
We had only changed the log level to DEBUG in release branch earlier.
But considering 90%+ of our deployments happen in same env, we can look
at these specific logs on need basis. With this change, the master
branch will be easier to debug with lesser logs.

Change-Id: I4157a7ec7d5ec9c2948b2bbc1e4cb8317f28d6b8
Updates: bz#1666833
Signed-off-by: Amar Tumballi <amarts@redhat.com>
This commit is contained in:
Amar Tumballi 2019-01-16 20:24:06 +05:30 committed by Shyamsundar Ranganathan
parent cf12a446f8
commit 990d6a99d4
4 changed files with 6 additions and 6 deletions
libglusterfs/src
dict.cgraph.coptions.c
rpc/xdr/src
glusterfs3.h

6
libglusterfs/src/dict.c

@ -39,14 +39,14 @@ struct dict_cmp {
#define VALIDATE_DATA_AND_LOG(data, type, key, ret_val) \
do { \
if (!data || !data->data) { \
gf_msg_callingfn("dict", GF_LOG_WARNING, EINVAL, \
LG_MSG_INVALID_ARG, "data is NULL"); \
gf_msg_callingfn("dict", GF_LOG_DEBUG, EINVAL, LG_MSG_INVALID_ARG, \
"data is NULL"); \
return ret_val; \
} \
/* Not of the asked type, or old version */ \
if ((data->data_type != type) && \
(data->data_type != GF_DATA_TYPE_STR_OLD)) { \
gf_msg_callingfn("dict", GF_LOG_INFO, EINVAL, LG_MSG_INVALID_ARG, \
gf_msg_callingfn("dict", GF_LOG_DEBUG, EINVAL, LG_MSG_INVALID_ARG, \
"key %s, %s type asked, has %s type", key, \
data_type_name[type], \
data_type_name[data->data_type]); \

2
libglusterfs/src/graph.c

@ -393,7 +393,7 @@ _log_if_unknown_option(dict_t *dict, char *key, data_t *value, void *data)
found = xlator_volume_option_get(xl, key);
if (!found) {
gf_msg(xl->name, GF_LOG_WARNING, 0, LG_MSG_XLATOR_OPTION_INVALID,
gf_msg(xl->name, GF_LOG_DEBUG, 0, LG_MSG_XLATOR_OPTION_INVALID,
"option '%s' is not recognized", key);
}

2
libglusterfs/src/options.c

@ -966,7 +966,7 @@ xl_opt_validate(dict_t *dict, char *key, data_t *value, void *data)
stub->errstr = errstr;
if (fnmatch(opt->key[0], key, FNM_NOESCAPE) != 0) {
gf_msg(xl->name, GF_LOG_WARNING, 0, LG_MSG_INVALID_ENTRY,
gf_msg(xl->name, GF_LOG_DEBUG, 0, LG_MSG_INVALID_ENTRY,
"option '%s' is deprecated, preferred is '%s', "
"continuing with correction",
key, opt->key[0]);

2
rpc/xdr/src/glusterfs3.h

@ -741,7 +741,7 @@ dict_to_xdr(dict_t *this, gfx_dict *dict)
xpair->value.gfx_value_u.other.other_len = dpair->value->len;
/* Change this to INFO, after taking the above down */
gf_msg("dict", GF_LOG_INFO, EINVAL, LG_MSG_DICT_SERIAL_FAILED,
gf_msg("dict", GF_LOG_DEBUG, EINVAL, LG_MSG_DICT_SERIAL_FAILED,
"key '%s' would not be sent on wire in the future",
dpair->key);
break;