andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

glusterd: Fix glusterd crash

Browse Source 
Problem: gluster get-state command is crashing glusterd process, when
geo-replication session is configured.

Cause: Crash is happening due to the double free of memory. In
glusterd_print_gsync_status_by_vol we are calling dict_unref(), which
will free all the keys and values in the dictionary. Before calling
dict_unref(), glusterd_print_gsync_status_by_vol is calling 
glusterd_print_gsync_status(). glusterd_print_gsync_status is freeing
up values in the dictionary and again when dict_unref() is called, it
tries to free up the values which are already freed.

Solution: Remove the code which will free the memory in
glusterd_print_gsync_status function.

Fixes: bz#1598345
Change-Id: Id3d8aae109f377b462bbbdb96a8e3c5f6b0be752
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
This commit is contained in:
Sanju Rakonde 2018-07-04 14:45:51 +05:30 committed by Atin Mukherjee
parent 06cdc95609
commit 99a1e816ce
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
xlators/mgmt/glusterd/src/glusterd-handler.c
View File

@ -5096,15 +5096,6 @@ glusterd_print_gsync_status (FILE *fp, dict_t *gsync_dict)
volcount, i+1, get_struct_variable(15, status_vals[i]));
}
out:
for (i = 0; i < gsync_count; i++) {
if (status_vals[i]) {
GF_FREE (status_vals[i]);
}
}
if (status_vals)
GF_FREE (status_vals);
return ret;
}