andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

geo-rep : fix few coverity issues in procdiggy.c

Browse Source 
This patch fixes BAD_FREE at line number 75,105 and
UNUSED_VALUE at line number 108.

CID : 1274068
scan detail at [1].
[1] https://scan6.coverity.com/reports.htm#v42401/p10714/fileInstanceId=84384726&defectInstanceId=25600457&mergedDefectId=727233

Change-Id: I8dff42546204bf78c178c9dcaba534888c5354e9
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
This commit is contained in:
Sunny Kumar 2018-07-31 19:03:05 +05:30 committed by Amar Tumballi
parent a3a3b8ec67
commit a0fb796c23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
geo-replication/src/procdiggy.c
View File

@ -72,8 +72,8 @@ pidinfo (pid_t pid, char **name)
out:
fclose (f);
if (pid == -1 && name && *name)
GF_FREE (name);
if (pid == -1 && name && *name)
GF_FREE (*name);
if (pid == -2)
fprintf (stderr, "out of memory\n");
return pid;
@ -104,8 +104,10 @@ prociter (int (*proch) (pid_t pid, pid_t ppid, char *tmpname, void *data),
if (gf_string2int (de->d_name, &pid) != -1 && pid >= 0) {
ppid = pidinfo (pid, &name);
switch (ppid) {
case -1: continue;
case -2: ret = -1; break;
case -1:
continue;
case -2:
break;
}
ret = proch (pid, ppid, name, data);
GF_FREE (name);