andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cluster/afr: Sync the parent directory's mtime during missing entries self-heal.

Browse Source 
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 137 (Parent directory mtime not reset after a create in self-heal)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=137
This commit is contained in:
Vikas Gorur 2009-12-07 05:44:31 +00:00 committed by Anand V. Avati
parent 0ae2b4be39
commit a12bfdc8f3
1 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
xlators/cluster/afr/src/afr-self-heal-common.c
View File

@ -834,6 +834,8 @@ sh_destroy_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
{
afr_local_t *local = NULL;
loc_t *parent_loc = cookie;
int call_count = 0;
local = frame->local;
@ -844,6 +846,11 @@ sh_destroy_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
local->loc.path, strerror (op_errno));
}
if (parent_loc) {
loc_wipe (parent_loc);
FREE (parent_loc);
}
call_count = afr_frame_return (frame);
if (call_count == 0) {
@ -869,6 +876,8 @@ sh_missing_entries_newentry_cbk (call_frame_t *frame, void *cookie,
int call_count = 0;
int child_index = 0;
loc_t *parent_loc = NULL;
struct stat stbuf;
int32_t valid;
@ -901,16 +910,27 @@ sh_missing_entries_newentry_cbk (call_frame_t *frame, void *cookie,
setattr_frame->local = CALLOC (1, sizeof (afr_local_t));
((afr_local_t *)setattr_frame->local)->call_count = 1;
((afr_local_t *)setattr_frame->local)->call_count = 2;
gf_log (this->name, GF_LOG_TRACE,
"setattr (%s) on subvolume %s",
local->loc.path, priv->children[child_index]->name);
STACK_WIND (setattr_frame, sh_destroy_cbk,
priv->children[child_index],
priv->children[child_index]->fops->setattr,
&local->loc, &stbuf, valid);
STACK_WIND_COOKIE (setattr_frame, sh_destroy_cbk,
(void *) (long) 0,
priv->children[child_index],
priv->children[child_index]->fops->setattr,
&local->loc, &stbuf, valid);
valid = GF_SET_ATTR_ATIME | GF_SET_ATTR_MTIME;
parent_loc = CALLOC (1, sizeof (*parent_loc));
afr_build_parent_loc (parent_loc, &local->loc);
STACK_WIND_COOKIE (setattr_frame, sh_destroy_cbk,
(void *) (long) parent_loc,
priv->children[child_index],
priv->children[child_index]->fops->setattr,
parent_loc, &sh->parentbuf, valid);
}
call_count = afr_frame_return (frame);
@ -1224,7 +1244,7 @@ sh_missing_entries_lookup_cbk (call_frame_t *frame, void *cookie,
buf->st_mode);
local->self_heal.buf[child_index] = *buf;
local->self_heal.parentbuf = *postparent;
} else {
gf_log (this->name, GF_LOG_TRACE,
"path %s on subvolume %s => -1 (%s)",