geo-rep: Do not restart workers when log-rsync-performance config change
Geo-rep restarts workers when any of the configurations changed. We don't need to restart workers if tunables like log-rsync-performance is modified. With this patch, Geo-rep workers will get new "log-rsync-performance" config automatically without restart. BUG: 1393678 Change-Id: I40ec253892ea7e70c727fa5d3c540a11e891897b Signed-off-by: Aravinda VK <avishwan@redhat.com> Reviewed-on: http://review.gluster.org/15816 NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Kotresh HR <khiremat@redhat.com>
This commit is contained in:
parent
c4b39198df
commit
a268e2865c
@ -1037,7 +1037,8 @@ class SlaveRemote(object):
|
||||
(boolify(gconf.sync_acls) and ['--acls'] or []) + \
|
||||
['.'] + list(args)
|
||||
|
||||
if gconf.log_rsync_performance:
|
||||
if boolify(gconf.configinterface.get_realtime(
|
||||
"log_rsync_performance")):
|
||||
# use stdout=PIPE only when log_rsync_performance enabled
|
||||
# Else rsync will write to stdout and nobody is their
|
||||
# to consume. If PIPE is full rsync hangs.
|
||||
@ -1056,7 +1057,8 @@ class SlaveRemote(object):
|
||||
for errline in stderr.strip().split("\n")[:-1]:
|
||||
logging.error("SYNC Error(Rsync): %s" % errline)
|
||||
|
||||
if gconf.log_rsync_performance:
|
||||
if boolify(gconf.configinterface.get_realtime(
|
||||
"log_rsync_performance")):
|
||||
rsync_msg = []
|
||||
for line in stdout.split("\n"):
|
||||
if line.startswith("Number of files:") or \
|
||||
|
@ -81,6 +81,8 @@ static char *gsync_reserved_opts[] = {
|
||||
|
||||
static char *gsync_no_restart_opts[] = {
|
||||
"checkpoint",
|
||||
"log_rsync_performance",
|
||||
"log-rsync-performance",
|
||||
NULL
|
||||
};
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user