andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cluster/dht: Log files skipped by rebalance

Browse Source 
There was no easy way to find out which files were
skipped during a rebalance.
Rebalance now logs a message for every skipped file
using msgid 109126, making it easier to find
all files that were skipped.

Change-Id: I2cac7db7285e2f82354251f3ea4094827b0daf3e
BUG: 1480445
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: https://review.gluster.org/18021
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: hari gowtham <hari.gowtham005@gmail.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
This commit is contained in:
N Balachandran 2017-08-11 12:16:12 +05:30 committed by Raghavendra G
parent 9420022df0
commit a4c43ba937
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
xlators/cluster/dht/src/dht-messages.h
View File

@ -40,7 +40,7 @@
*/
#define GLFS_DHT_BASE GLFS_MSGID_COMP_DHT
#define GLFS_DHT_NUM_MESSAGES 125
#define GLFS_DHT_NUM_MESSAGES 126
#define GLFS_MSGID_END (GLFS_DHT_BASE + GLFS_DHT_NUM_MESSAGES + 1)
/* Messages with message IDs */
@ -1134,5 +1134,12 @@
*/
#define DHT_MSG_UNKNOWN_FOP (GLFS_DHT_BASE + 125)
/*
* @messageid 109126
* @diagnosis
* @recommendedaction None
*/
#define DHT_MSG_MIGRATE_FILE_SKIPPED (GLFS_DHT_BASE + 126)
#define glfs_msg_end_x GLFS_MSGID_END, "Invalid: End of messages"
#endif /* _DHT_MESSAGES_H_ */

11
xlators/cluster/dht/src/dht-rebalance.c
View File

@ -2674,6 +2674,11 @@ gf_defrag_migrate_single_file (void *opaque)
defrag->skipped += 1;
}
UNLOCK (&defrag->lock);
gf_msg (this->name, GF_LOG_INFO, 0,
DHT_MSG_MIGRATE_FILE_SKIPPED,
"File migration skipped for %s.",
entry_loc.path);
}
} else if (fop_errno == ENOTSUP) {
@ -2684,6 +2689,12 @@ gf_defrag_migrate_single_file (void *opaque)
defrag->skipped += 1;
}
UNLOCK (&defrag->lock);
gf_msg (this->name, GF_LOG_INFO, 0,
DHT_MSG_MIGRATE_FILE_SKIPPED,
"File migration skipped for %s.",
entry_loc.path);
} else if (fop_errno != EEXIST) {
gf_msg (this->name, GF_LOG_ERROR, fop_errno,
DHT_MSG_MIGRATE_FILE_FAILED,