andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gfapi: acutally avoid recall callback when closed

Browse Source 
Due to missing curly braces we end up calling the callback
function even when state is GLFD_CLOSE. This patch adds the
curly braces so both the log and actual callback is skipped.

  Introduced in 19568 in commit b04066721bf4a240f61b83bd87bbb27437c5fe4f

Change-Id: I0b15cfe222841cfcb12f17723284acb3838d64d7
fixes: bz#1575294
Signed-off-by: Thomas Hindoe Paaboel Andersen <phomes@gmail.com>
This commit is contained in:
Thomas Hindoe Paaboel Andersen 2018-05-05 20:23:32 +02:00 committed by Shyamsundar Ranganathan
parent 9e739aef97
commit a6490fe021
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
api/src/glfs-fops.c
View File

@ -5180,11 +5180,12 @@ glfs_recall_lease_fd (struct glfs *fs,
list_for_each_entry_safe (glfd, tmp, &glfd_list, list) {
LOCK (&glfd->lock);
{
if (glfd->state != GLFD_CLOSE)
if (glfd->state != GLFD_CLOSE) {
gf_msg_trace (THIS->name, 0,
"glfd (%p) has held lease, "
"calling recall cbk", glfd);
glfd->cbk (lease, glfd->cookie);
}
}
UNLOCK (&glfd->lock);