andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cli: Fix memory leaks reported by ASAN

Browse Source 
This patch addresses memory leaks other than
'gf_cli_rsp' response structure.

Updates: bz#1633930
Change-Id: Idc5940dca623e33bc01004a9324bc435fc60b006
Signed-off-by: Kotresh HR <khiremat@redhat.com>
This commit is contained in:
Kotresh HR 2018-10-11 23:39:13 +05:30 committed by Amar Tumballi
parent f678946261
commit ac074e0343
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
cli/src/cli-rpc-ops.c
View File

@ -111,6 +111,28 @@ gf_free_xdr_cli_rsp(gf_cli_rsp rsp)
}
}
static void
gf_free_xdr_getspec_rsp(gf_getspec_rsp rsp)
{
if (rsp.spec) {
free(rsp.spec);
}
if (rsp.xdata.xdata_val) {
free(rsp.xdata.xdata_val);
}
}
static void
gf_free_xdr_fsm_log_rsp(gf1_cli_fsm_log_rsp rsp)
{
if (rsp.op_errstr) {
free(rsp.op_errstr);
}
if (rsp.fsm_log.fsm_log_val) {
free(rsp.fsm_log.fsm_log_val);
}
}
int
gf_cli_probe_cbk(struct rpc_req *req, struct iovec *iov, int count,
void *myframe)
@ -503,6 +525,9 @@ out:
if (dict)
dict_unref(dict);
if (rsp.friends.friends_val) {
free(rsp.friends.friends_val);
}
return ret;
}
@ -4291,6 +4316,7 @@ gf_cli_getspec_cbk(struct rpc_req *req, struct iovec *iov, int count,
out:
cli_cmd_broadcast_response(ret);
gf_free_xdr_getspec_rsp(rsp);
return ret;
}
@ -5532,6 +5558,11 @@ gf_cli_fsm_log_cbk(struct rpc_req *req, struct iovec *iov, int count,
out:
cli_cmd_broadcast_response(ret);
if (dict) {
dict_unref(dict);
}
gf_free_xdr_fsm_log_rsp(rsp);
return ret;
}
@ -7006,6 +7037,10 @@ gf_cli_getwd_cbk(struct rpc_req *req, struct iovec *iov, int count,
out:
cli_cmd_broadcast_response(ret);
if (rsp.wd) {
free(rsp.wd);
}
return ret;
}
@ -8622,6 +8657,9 @@ gf_cli_mount_cbk(struct rpc_req *req, struct iovec *iov, int count,
out:
cli_cmd_broadcast_response(ret);
if (rsp.path) {
free(rsp.path);
}
return ret;
}