andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

coverity: last of the secure temp fixes

Browse Source 
Coverity ignore directive is not working if the comment is
split across lines (or has an empty line at the end.

This can be seen in this report:
https://download.gluster.org/pub/gluster/glusterfs/static-analysis
  /master/glusterfs-coverity/2018-08-06-b982e09f/html/1
  /384glusterfsd-mgmt.c.html#error

In other places the same pattern has avoided coverity from
flagging off the same call, except here.

Updates: bz#789278

Change-Id: Ic35ff0fc91d0a42904630728ef7c18215aa277f3
Signed-off-by: ShyamsundarR <srangana@redhat.com>
This commit is contained in:
ShyamsundarR 2018-08-06 19:40:30 -04:00 committed by Amar Tumballi
parent 93c9062ccd
commit bd35aa2aa3
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glusterfsd/src/glusterfsd-mgmt.c
View File

@ -1992,9 +1992,7 @@ volfile:
}
}
/* coverity[secure_temp] mkstemp uses 0600 as the mode and is
* safe
*/
/* coverity[secure_temp] mkstemp uses 0600 as the mode */
tmp_fd = mkstemp (template);
if (-1 == tmp_fd) {
gf_msg (frame->this->name, GF_LOG_ERROR, 0,