andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

logging: Fix GF_LOG_OCCASSIONALLY API

Browse Source 
GF_LOG_OCCASSIONALLY doesn't log on the first instance rather at every
42nd iterations which isn't effective as in some cases we might not have
the code flow hitting the same log for as many as 42 times and we'd end
up suppressing the log.

Updates: bz#1679904
Change-Id: Iee293281d25a652b64df111d59b13de4efce06fa
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
(cherry picked from commit d0d3e10d44366c68fc153e48b229e72a4aa26e61)
This commit is contained in:
Atin Mukherjee 2019-04-02 10:45:15 +05:30 committed by Shyamsundar Ranganathan
parent 55c5e2ecc7
commit c2723c57d2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libglusterfs/src/glusterfs/logging.h
View File

@ -300,7 +300,7 @@ _gf_log_eh(const char *function, const char *fmt, ...)
/* Log once in GF_UNIVERSAL_ANSWER times */
#define GF_LOG_OCCASIONALLY(var, args...) \
if (!(var++ % GF_UNIVERSAL_ANSWER)) { \
if (var++ == 0 || !((var - 1) % GF_UNIVERSAL_ANSWER)) { \
gf_log(args); \
}