andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

server.c: fix Coverity CID 1399758

Browse Source 
1399758 Dereference before null check

It was introduced @ commit 67f48bfcc16a38052e6c9ae7c25e69b03b8ae008

updates: bz#1691187
> updates: bz#789278
> Signed-off-by: Yaniv Kaul <ykaul@redhat.com>

> Change-Id: I1424b008b240691fe2a8924e31c708d0fb4f362d
> (cherry picked from commit 8aff9cc5c6277ef7dacfb89f1392b7c2eda9b825)

Change-Id: Ie2160fb9ae9cdeacf845e849da7f6001b3b6b10b
This commit is contained in:
Yaniv Kaul 2019-03-20 13:05:44 +02:00 committed by MOHIT AGRAWAL
parent 3fadf5cc41
commit cba59f6cb7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
xlators/protocol/server/src/server.c
View File

@ -438,7 +438,6 @@ server_rpc_notify(rpcsvc_t *rpc, void *xl, rpcsvc_event_t event, void *data)
this = xl;
trans = data;
conf = this->private;
if (!this || !data || !this->ctx || !this->ctx->active) {
gf_msg_callingfn("server", GF_LOG_WARNING, 0, PS_MSG_RPC_NOTIFY_ERROR,
@ -446,6 +445,8 @@ server_rpc_notify(rpcsvc_t *rpc, void *xl, rpcsvc_event_t event, void *data)
goto out;
}
conf = this->private;
switch (event) {
case RPCSVC_EVENT_ACCEPT: {
/* Have a structure per new connection */