andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cli: Adding warning message while creating a replica 2 volume

Browse Source 
Warn the CLI about ending up in split-brain situation with a
replica 2 volume. Display arbiter and replica 3 are recommended
option to avoid this and point to the document on split-brain
and ways to deal with it.

Change-Id: I7f31f3c74818d440a684b3130bc5ccdc72258f01
BUG: 1431963
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Reviewed-on: https://review.gluster.org/16899
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
This commit is contained in:
karthik-us 2017-03-14 13:17:11 +05:30 committed by Pranith Kumar Karampuri
parent fb66df4c44
commit db0e5582b1
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
cli/src/cli-cmd-parser.c
View File

@ -456,6 +456,8 @@ cli_cmd_volume_create_parse (struct cli_state *state, const char **words,
int32_t disperse_data_count = -1;
gf_boolean_t is_force = _gf_false;
int wc = wordcount;
gf_answer_t answer = GF_ANSWER_NO;
const char *question = NULL;
GF_ASSERT (words);
GF_ASSERT (options);
@ -526,6 +528,22 @@ cli_cmd_volume_create_parse (struct cli_state *state, const char **words,
ret = -1;
goto out;
}
if (replica_count == 2) {
question = "Replica 2 volumes are prone to "
"split-brain. Use Arbiter or Replica"
" 3 to avoid this. See: "
" https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Split%20brain%20and%20ways%20to%20deal%20with%20it/."
"\nDo you still want to continue?\n";
answer = cli_cmd_get_confirmation (state,
question);
if (GF_ANSWER_NO == answer) {
gf_log ("cli", GF_LOG_ERROR,
"Volume create cancelled, "
"exiting");
ret = -1;
goto out;
}
}
ret = dict_set_int32 (dict, "replica-count", replica_count);
if (ret)
goto out;