andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

snapshot : fix few coverity issues in glusterd-snapshot-utils.c

Browse Source 
This patch fixes CID 1210987 and 1351650.

Change-Id: Ic85bc6048651146a79fe68add19dcc095738a517
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
This commit is contained in:
Sunny Kumar 2018-08-07 19:02:48 +05:30 committed by Amar Tumballi
parent b76a84be69
commit dcacaf15ec
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
xlators/mgmt/glusterd/src/glusterd-snapshot-utils.c
View File

@ -3074,6 +3074,7 @@ glusterd_snap_common_quorum_calculate (glusterd_volinfo_t *volinfo,
this = THIS;
GF_ASSERT (this);
GF_VALIDATE_OR_GOTO (this->name, op_errno, out);
GF_VALIDATE_OR_GOTO (this->name, volinfo, out);
/* for replicate volumes with replica count equal to or
greater than 3, do quorum check by getting what type
@ -3275,7 +3276,7 @@ glusterd_snap_quorum_check_for_clone (dict_t *dict, gf_boolean_t snap_volume,
if (ret) {
gf_msg (this->name, GF_LOG_WARNING, 0,
GD_MSG_VOL_NOT_FOUND, "volume %s "
"is not in quorum", volinfo->volname);
"is not in quorum", volname);
goto out;
}
}
@ -3990,7 +3991,7 @@ glusterd_restore_geo_rep_files (glusterd_volinfo_t *snap_vol)
}
out:
if (origin_volname)
GF_ASSERT (origin_volname);
GF_FREE (origin_volname);
return ret;
}