andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fuse-bridge: Don't try to fill a loc in setattr when we can proceed on with an fd.

Browse Source 
This fixes broken ftruncate on unlinked files.

Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 472 (OpenOffice fails on GlusterFS $HOME due to fuse_loc_fill error)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=472
This commit is contained in:
Csaba Henk 2009-12-18 07:51:12 +00:00 committed by Vijay Bellur
parent 40541428c7
commit ea18fce5cd
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
xlators/mount/fuse/src/fuse-bridge.c
View File

@ -991,7 +991,14 @@ fuse_setattr (xlator_t *this, fuse_in_header_t *finh, void *msg)
GET_STATE (this, finh, state);
ret = fuse_loc_fill (&state->loc, state, finh->nodeid, 0, NULL);
if (fsi->valid & FATTR_FH &&
!(fsi->valid & (FATTR_ATIME|FATTR_MTIME)))
/* We need no loc if kernel sent us an fd and
* we are not fiddling with times */
ret = 1;
else
ret = fuse_loc_fill (&state->loc, state, finh->nodeid, 0,
NULL);
/*
* This is just stub code demonstrating how to retrieve
@ -1010,7 +1017,7 @@ fuse_setattr (xlator_t *this, fuse_in_header_t *finh, void *msg)
if (priv->proto_minor >= 9 && fsi->valid & FATTR_LOCKOWNER)
state->lk_owner = fsi->lock_owner;
if ((state->loc.inode == NULL) ||
if ((state->loc.inode == NULL && ret == 0) ||
(ret < 0)) {
gf_log ("glusterfs-fuse", GF_LOG_WARNING,