andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cli: fix memory leak in cli rpc ops

Browse Source 
Problem: In some of the cli fops dict_allocate_and_serialize
         allocate memory for req structure but after submit
         request it missed to cleanup memory fo req.dict.dict_val

Solution: Call GF_FREE for req.dict.dict_val after submit
          cli request

Change-Id: I76c6b3082fa0be21dc595f87701550a318734ea5
updates: bz#1633930
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
This commit is contained in:
Mohit Agrawal 2018-12-06 22:02:28 +05:30 committed by Atin Mukherjee
parent 4bdabc49d0
commit f168db1da7
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cli/src/cli-rpc-ops.c
View File

@ -4108,6 +4108,7 @@ cli_quotad_getlimit(call_frame_t *frame, xlator_t *this, void *data)
cli_quotad_getlimit_cbk, (xdrproc_t)xdr_gf_cli_req);
out:
GF_FREE(req.dict.dict_val);
gf_log("cli", GF_LOG_DEBUG, "Returning %d", ret);
return ret;
}
@ -4846,6 +4847,7 @@ gf_cli_rename_volume(call_frame_t *frame, xlator_t *this, void *data)
gf_cli_rename_volume_cbk, (xdrproc_t)xdr_gf_cli_req);
out:
GF_FREE(req.dict.dict_val);
gf_log("cli", GF_LOG_DEBUG, "Returning %d", ret);
return ret;
@ -5420,6 +5422,7 @@ out:
if (op_dict) {
dict_unref(op_dict);
}
GF_FREE(req.xdata.xdata_val);
gf_log("cli", GF_LOG_DEBUG, "Returning %d", ret);
return ret;
@ -8708,6 +8711,7 @@ gf_cli_mount(call_frame_t *frame, xlator_t *this, void *data)
(xdrproc_t)xdr_gf1_cli_mount_req);
out:
GF_FREE(req.dict.dict_val);
gf_log("cli", GF_LOG_DEBUG, "Returning %d", ret);
return ret;
}