andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

glusterfsd: Fix coverity issues around unused values

Browse Source 
This patch fixes,
CID: 1274064, 1274232

The fix is to not add into the return dict the throughput
and time values on error computing the same. The pattern
applied is the same as when an error occurs during adding
either the throughput or the time value to the dict.

Change-Id: I33e21e75efbc691f18b818934ef3bf70dd075097
Updates: bz#789278
Signed-off-by: ShyamsundarR <srangana@redhat.com>
This commit is contained in:
ShyamsundarR 2018-10-15 20:50:26 -04:00 committed by Amar Tumballi
parent f50625e7b0
commit f179d09326
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glusterfsd/src/glusterfsd-mgmt.c
View File

@ -416,6 +416,8 @@ glusterfs_handle_translator_info_get(rpcsvc_request_t *req)
ret = glusterfs_volume_top_write_perf(
blk_size, blk_count, xlator_req.name, &throughput, &time);
}
if (ret)
goto cont;
ret = dict_set_double(dict, "time", time);
if (ret)
goto cont;