andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

refcount: typecast function for calling on free

Browse Source 
All of the functions called to free the refcounted structure are doing a
typecast from (void*) to their own type taht is being free'd. This
really is not needed and the refcount interface is made a little simpler
without the requirement of typecasting.

With this small improvement in the API, all callers are updated too.

Change-Id: I32473b6d1799f62861d4b2d78ea30c09e6c80ab1
BUG: 1416889
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/16471
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
This commit is contained in:
Niels de Vos 2017-01-26 16:45:51 +01:00 committed by Raghavendra G
parent 1a95fc3036
commit f2ca301bd7
6 changed files with 10 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
api/src/glfs.c
View File

@ -583,16 +583,12 @@ pub_glfs_from_glfd (struct glfs_fd *glfd)
GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_from_glfd, 3.4.0);
void
glfs_fd_destroy (void *data)
static void
glfs_fd_destroy (struct glfs_fd *glfd)
{
struct glfs_fd *glfd = NULL;
if (!data)
if (!glfd)
return;
glfd = (struct glfs_fd *)data;
glfs_lock (glfd->fs, _gf_true);
{
list_del_init (&glfd->openfds);

2
libglusterfs/src/refcount.h
View File

@ -84,7 +84,7 @@ _gf_ref_init (gf_ref_t *ref, gf_ref_release_t release, void *data);
*
* Sets the refcount to 1.
*/
#define GF_REF_INIT(p, d) _gf_ref_init (&(p)->_ref, d, p)
#define GF_REF_INIT(p, d) _gf_ref_init (&(p)->_ref, (gf_ref_release_t) d, p)
/* GF_REF_GET -- increase the refcount of a GF_REF_DECL structure
*

6
rpc/rpc-transport/socket/src/socket.c
View File

@ -3841,11 +3841,9 @@ init_openssl_mt (void)
SSL_load_error_strings();
}
void
socket_poller_mayday (void *data)
static void
socket_poller_mayday (socket_private_t *priv)
{
socket_private_t *priv = (socket_private_t *)data;
if (priv == NULL)
return;

9
xlators/cluster/dht/src/dht-helper.c
View File

@ -15,15 +15,10 @@
#include "dht-helper.h"
void
dht_free_fd_ctx (void *data)
static void
dht_free_fd_ctx (dht_fd_ctx_t *fd_ctx)
{
dht_fd_ctx_t *fd_ctx = NULL;
fd_ctx = (dht_fd_ctx_t *)data;
GF_FREE (fd_ctx);
return;
}

6
xlators/features/marker/src/marker-quota-helper.c
View File

@ -146,11 +146,9 @@ out:
return ctx;
}
void
mq_contri_fini (void *data)
static void
mq_contri_fini (inode_contribution_t *contri)
{
inode_contribution_t *contri = data;
LOCK_DESTROY (&contri->lock);
GF_FREE (contri);
}

3
xlators/features/marker/src/marker-quota-helper.h
View File

@ -66,9 +66,6 @@ mq_local_ref (quota_local_t *);
int32_t
mq_local_unref (xlator_t *, quota_local_t *);
void
mq_contri_fini (void *data);
inode_contribution_t*
mq_contri_init (inode_t *inode);