andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

features/changelog: fix possible illegal mem access (CID 1288822)

Browse Source 
Coverity CID 1288822 (#1 of 2)

strncpy executed with a limit equal to the target array
size potentially leaves the target string not null terminated.

In this case the strncpy is not needed due to the snprintf
with the same target buffer which follows immediately.

This patch also removes the now unneeded scratch_dir
argument to gf_changelog_init_history(), which is semantically
correct, since scratch_dir has previously been filled into
jnl->jnl_working_dir by the caller, and this is now used to
fill hist_scratch_dir.

Change-Id: Ib1ed3a1058e80e34191758921b49c29030d6c9db
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10058
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
This commit is contained in:
Michael Adam 2015-03-31 02:28:07 +02:00 committed by Vijay Bellur
parent 41bc3f7f02
commit f4be9bc3c5
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
xlators/features/changelog/lib/src/gf-changelog-journal-handler.c
View File

@ -842,7 +842,7 @@ gf_changelog_open_dirs (xlator_t *this, gf_changelog_journal_t *jnl)
int
gf_changelog_init_history (xlator_t *this,
gf_changelog_journal_t *jnl,
char *brick_path, char *scratch_dir)
char *brick_path)
{
int i = 0;
int ret = 0;
@ -856,7 +856,6 @@ gf_changelog_init_history (xlator_t *this,
jnl->hist_jnl->jnl_dir = NULL;
jnl->hist_jnl->jnl_fd = -1;
(void) strncpy (hist_scratch_dir, scratch_dir, PATH_MAX);
(void) snprintf (hist_scratch_dir, PATH_MAX,
"%s/"GF_CHANGELOG_HISTORY_DIR"/",
jnl->jnl_working_dir);
@ -957,8 +956,7 @@ gf_changelog_journal_init (void *xl, struct gf_brick_spec *brick)
i == '-' || i == '.' || i == '_') ? i : 0;
}
ret = gf_changelog_init_history (this, jnl,
brick->brick_path, scratch_dir);
ret = gf_changelog_init_history (this, jnl, brick->brick_path);
if (ret)
goto cleanup_fds;