andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

glfs-fops.c: fix the bad string length for snprintf

Browse Source 
Snprintf reserves one byte for the ending '\0'.
A NAME_MAX bytes d_name is truncated to NAME_MAX - 1 bytes.

Change-Id: Ic884d18cee24360e55ddb896dc587b0b74ef97fe
updates: bz#1193929
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
This commit is contained in:
Kinglong Mee 2019-01-03 17:07:27 +08:00 committed by Niels de Vos
parent a9b0003c71
commit f99f51ca87
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
api/src/glfs-fops.c
View File

@ -3413,7 +3413,7 @@ gf_dirent_to_dirent(gf_dirent_t *gf_dirent, struct dirent *dirent)
dirent->d_namlen = strlen(gf_dirent->d_name);
#endif
snprintf(dirent->d_name, NAME_MAX, "%s", gf_dirent->d_name);
snprintf(dirent->d_name, NAME_MAX + 1, "%s", gf_dirent->d_name);
}
int
@ -4904,7 +4904,7 @@ retry:
goto out;
if (loc.path) {
snprintf(retpath, PATH_MAX, "%s", loc.path);
snprintf(retpath, PATH_MAX + 1, "%s", loc.path);
}
out: