Regression test portability: TAP
Even with successful tests on NetBSD, we had a failure message at the end: "No plan found in TAP output" This was caused by a white space left padded numerical variable. Stripping the white spaces fixes the problem. While there add SKIP_TEST for NetBSD on unspported tests so that it does not triger a failure. BUG: 1129939 Change-Id: I8d0bc125c4208974657977568d838ee2dd19783c Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org> Reviewed-on: http://review.gluster.org/8981 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
This commit is contained in:
parent
886eb63fc7
commit
fb2e0a4afb
@ -74,6 +74,7 @@ function volume_type()
|
||||
case $OSTYPE in
|
||||
NetBSD)
|
||||
echo "Skip test on LVM which is not available on NetBSD" >&2
|
||||
SKIP_TESTS
|
||||
exit 0
|
||||
;;
|
||||
*)
|
||||
|
@ -97,7 +97,7 @@ for line in $expect_tests; do
|
||||
done
|
||||
IFS=$x_ifs
|
||||
|
||||
echo 1..$testcnt
|
||||
echo "1..`echo $testcnt`"
|
||||
|
||||
t=1
|
||||
|
||||
|
@ -394,6 +394,7 @@ function check_if_snapd_exist() {
|
||||
case $OSTYPE in
|
||||
NetBSD)
|
||||
echo "Skip test on LVM which is not available on NetBSD" >&2
|
||||
SKIP_TESTS
|
||||
exit 0
|
||||
;;
|
||||
*)
|
||||
|
Loading…
x
Reference in New Issue
Block a user