andy/glusterfs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

inode: 'this' has been set unwantedly.

Browse Source 
Problem:
  CC       libglusterfs_la-inode.lo
inode.c: In function 'inode_table_destroy':
inode.c:1630:19: warning: variable 'this' set
but not used [-Wunused-but-set-variable]
         xlator_t *this = NULL;

Change-Id: If4b37ab896ee0a309826d4be48c6599d6ec2710b
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
Reviewed-on: http://review.gluster.org/9846
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
This commit is contained in:
Humble Devassy Chirammal 2015-03-09 19:12:03 +05:30 committed by Niels de Vos
parent 71210c021f
commit fb6858b475
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libglusterfs/src/inode.c
View File

@ -1627,11 +1627,8 @@ inode_table_destroy_all (glusterfs_ctx_t *ctx) {
void
inode_table_destroy (inode_table_t *inode_table) {
xlator_t *this = NULL;
inode_t *tmp = NULL, *trav = NULL;
this = THIS;
if (inode_table == NULL)
return;
@ -1642,8 +1639,8 @@ inode_table_destroy (inode_table_t *inode_table) {
* in lru list.(If no leaks there should be no inodes in active list)
* 2. Knowing there could be leaks and not freeing those inodes will
* also not free its inode context and this could leak a lot of
* memory, force free the inodes by changeing the ref to 0.
* The problem with this is that any refence ti inode after this
* memory, force free the inodes by changing the ref to 0.
* The problem with this is that any reference to inode after this
* calling this funtion will lead to a crash.
* 3. Knowing there could be leakes, just free the inode contexts of
* all the inodes. and let the inodes be alive. This way the major